superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] villebro commented on pull request #9752: fix(mssql): CAST with AT produces statements with syntax errors
Date Wed, 06 May 2020 15:26:25 GMT

villebro commented on pull request #9752:
URL: https://github.com/apache/incubator-superset/pull/9752#issuecomment-624716939


   This is really a can of worms, and the deeper we go the more `sqlparse`-like logic we'll
be introducing into Superset with unpleasant maintenance burden. I would almost propose deprecating
advanced limiting for `TOP`-syntax dialects.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message