superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9724: docs(api): improve openapi documentation for dash, charts and queries
Date Mon, 04 May 2020 16:08:26 GMT

dpgaspar commented on a change in pull request #9724:
URL: https://github.com/apache/incubator-superset/pull/9724#discussion_r419550433



##########
File path: superset/charts/api.py
##########
@@ -509,20 +516,14 @@ def thumbnail(
             FileWrapper(screenshot), mimetype="image/png", direct_passthrough=True
         )
 
-    def add_apispec_components(self, api_spec: APISpec) -> None:
-        for chart_type in CHART_DATA_SCHEMAS:
-            api_spec.components.schema(
-                chart_type.__name__, schema=chart_type,
-            )
-        super().add_apispec_components(api_spec)
-

Review comment:
       moved it to base, we can now set these kind of things using `openapi_spec_component_schemas`
class attr.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message