superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] nytai edited a comment on pull request #9692: [sqllab] fix, strip comments before parsing statements
Date Fri, 01 May 2020 21:21:21 GMT

nytai edited a comment on pull request #9692:
URL: https://github.com/apache/incubator-superset/pull/9692#issuecomment-622572706


   @dpgaspar it looks like SQL_QUERY_MUTATOR is applied after. However it is called with the
original (unparsed) sql query, which I think is also what is actually passed to the engine.
This change only applies to the parsed_sql which is used for validation purposes only, I believe.



----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message