superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] nytai commented on pull request #9692: [sqllab] fix, strip comments before parsing statements
Date Fri, 01 May 2020 19:47:24 GMT

nytai commented on pull request #9692:
URL: https://github.com/apache/incubator-superset/pull/9692#issuecomment-622536056


   Additionally `sqlparse` doesn't seem to tag comments. The type it's resolving `-- some
comment` to is `'UNKNOWN'`. We could add `UNKNOWN` to the `is_readonly` check, but that seems
less safe than strictly treating only `SELECT|EXPLAIN` as readonly


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message