superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] aspedrosa commented on issue #9674: Public Role
Date Fri, 01 May 2020 16:22:03 GMT

aspedrosa commented on issue #9674:
URL: https://github.com/apache/incubator-superset/issues/9674#issuecomment-622455942


   @MarcusSorealheis 
   I think what @iamklaus is trying to do is to access dashboards without logging in.
   I have a similar/related issue. I'm not setting PUBLIC_ROLE_LIKE_GAMMA to True but I'm
giving the necessary permissions to the public role so he can access a dashboard, however
without success.
   
   I think the problem is on the method get_public_role of the SupersetSecurityManager [here](https://github.com/apache/incubator-superset/blob/master/superset/security/manager.py#L368)
:point_down: 
   
   ```
   if not conf.get("PUBLIC_ROLE_LIKE_GAMMA", False):
       return None
   
   from superset import db
   
   return db.session.query(self.role_model).filter_by(name="Public").first()
   ```
   
   Shouldn't it be like this :point_down: ?
   ```
   from superset import db
   
   if conf.get("PUBLIC_ROLE_LIKE_GAMMA", False):
       return db.session.query(self.role_model).filter_by(name="Gamma").first()
   
   return db.session.query(self.role_model).filter_by(name="Public").first()
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message