From notifications-return-27591-archive-asf-public=cust-asf.ponee.io@superset.apache.org Sat Sep 21 18:29:47 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 11642180642 for ; Sat, 21 Sep 2019 20:29:46 +0200 (CEST) Received: (qmail 97368 invoked by uid 500); 21 Sep 2019 18:29:46 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 97359 invoked by uid 99); 21 Sep 2019 18:29:46 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 21 Sep 2019 18:29:46 +0000 From: GitBox To: notifications@superset.apache.org Subject: [GitHub] [incubator-superset] benvdh commented on a change in pull request #8276: More intuitive display of negative time deltas (#8274) Message-ID: <156909058623.8591.10385234055955738683.gitbox@gitbox.apache.org> Date: Sat, 21 Sep 2019 18:29:46 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit benvdh commented on a change in pull request #8276: More intuitive display of negative time deltas (#8274) URL: https://github.com/apache/incubator-superset/pull/8276#discussion_r326869661 ########## File path: superset/utils/core.py ########## @@ -349,6 +349,23 @@ def datetime_f(dttm): return "{}".format(dttm) +def timedelta_f(td: timedelta) -> str: Review comment: Done anyway. We can always revert if necessary. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org