From notifications-return-27458-archive-asf-public=cust-asf.ponee.io@superset.apache.org Thu Sep 19 07:35:58 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2658418062C for ; Thu, 19 Sep 2019 09:35:58 +0200 (CEST) Received: (qmail 81150 invoked by uid 500); 19 Sep 2019 07:35:57 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 81141 invoked by uid 99); 19 Sep 2019 07:35:57 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Sep 2019 07:35:57 +0000 From: GitBox To: notifications@superset.apache.org Subject: [GitHub] [incubator-superset] graceguo-supercat commented on a change in pull request #8256: [sql_json] Ensuring the request body is JSON encoded Message-ID: <156887855733.11147.11328485938574534852.gitbox@gitbox.apache.org> Date: Thu, 19 Sep 2019 07:35:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit graceguo-supercat commented on a change in pull request #8256: [sql_json] Ensuring the request body is JSON encoded URL: https://github.com/apache/incubator-superset/pull/8256#discussion_r326028235 ########## File path: superset/assets/src/SqlLab/actions/sqlLab.js ########## @@ -220,9 +220,9 @@ export function runQuery(query) { }; return SupersetClient.post({ - endpoint: `/superset/sql_json/${window.location.search}`, - postPayload, - stringify: false, + endpoint: '/superset/sql_json/', Review comment: you will see we use post method in many, many places, only in sql lab added `stringify: false`. I assume there must be reason to do extra... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org