superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] villebro edited a comment on issue #8183: How to pass time filters to SQL Lab queries
Date Sat, 28 Sep 2019 03:44:51 GMT
villebro edited a comment on issue #8183: How to pass time filters to SQL Lab queries
URL: https://github.com/apache/incubator-superset/issues/8183#issuecomment-536112676
 
 
   @rubypollev the proposed approach makes sense, especially reusing existing code from `utils.core`.
However, if memory serves me right, `BETWEEN` might mean different things depending on the
dialect; sometimes inclusive, sometimes not (I might be wrong, though). Anyway, In `connectors/sqla/models.py`,
`get_time_filter()` creates `<=` and/or `>=` where clauses, so probably a good idea
to stick to that logic. While it might be difficult to leverage SqlAlchemy Core functionality
in this case (might be feasible, not sure), I think it makes sense to try to diverge from
the default logic as much as possible. So prior to submitting a PR I would advise to at least
change the `BETWEEN` operator to `<=` and/or `>=` operator(s), with additional bonus
for utilizing any existing code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message