superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] benvdh commented on a change in pull request #8276: More intuitive display of negative time deltas (#8274)
Date Sat, 21 Sep 2019 18:19:49 GMT
benvdh commented on a change in pull request #8276: More intuitive display of negative time
deltas (#8274)
URL: https://github.com/apache/incubator-superset/pull/8276#discussion_r326869410
 
 

 ##########
 File path: superset/utils/core.py
 ##########
 @@ -349,6 +349,23 @@ def datetime_f(dttm):
     return "<nobr>{}</nobr>".format(dttm)
 
 
+def timedelta_f(td: timedelta) -> str:
 
 Review comment:
   @villebro I agree `format_timedelta` is clearer. It was actually what I used while developing,
 until I noticed that there was already another function called `datetime_f` in the same module
which did a similar thing for datetimes. Renaming would remove consistency in naming again.

   
   Would you still like me to make that change? (renaming both seems a bit beyond the scope
of this pull request)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message