superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] dpgaspar edited a comment on issue #8254: WIP. Avoid circular dependency between superset config and superset package
Date Thu, 19 Sep 2019 13:46:22 GMT
dpgaspar edited a comment on issue #8254: WIP. Avoid circular dependency between superset config
and superset package
URL: https://github.com/apache/incubator-superset/pull/8254#issuecomment-533137242
 
 
   I would rename `superset/security/security.py` to `superset/security/manager.py`.
   You need to add the Apache license to `superset/security/__init__.py`
   
   I nice to have could be to import `SupersetSecurityManager` on the __init__.py, it would
minimize any breaking changes

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message