superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] etr2460 commented on a change in pull request #8256: [sql_json] Ensuring the request body is JSON encoded
Date Thu, 19 Sep 2019 04:44:49 GMT
etr2460 commented on a change in pull request #8256: [sql_json] Ensuring the request body is
JSON encoded
URL: https://github.com/apache/incubator-superset/pull/8256#discussion_r325986612
 
 

 ##########
 File path: superset/assets/src/SqlLab/actions/sqlLab.js
 ##########
 @@ -220,9 +220,9 @@ export function runQuery(query) {
     };
 
     return SupersetClient.post({
-      endpoint: `/superset/sql_json/${window.location.search}`,
-      postPayload,
-      stringify: false,
+      endpoint: '/superset/sql_json/',
 
 Review comment:
   don't we really want `stringify: false`? I was under the impression that prevented us from
sending up `"null"` and `"false"` versus `null` and `false`
   
   And parseMethod determines how we parse the response, not the request

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message