serenajiang opened a new pull request #8255: [sqllab] Make sure null schema is `None` and not
`"null"`
URL: https://github.com/apache/incubator-superset/pull/8255
### CATEGORY
Choose one
- [X] Bug Fix
- [ ] Enhancement (new features, refinement)
- [ ] Refactor
- [ ] Add tests
- [ ] Build / Development Environment
- [ ] Documentation
### SUMMARY
A null schema in the request form is interpreted as the string `"null"` rather than actual
`null`, resulting in `/sql_json/` returning a response containing "null". This causes problems.
These problems can be better explained by @john-bodley.
Just a one line change to make sure `"null"` is translated into Python `None`.
### TEST PLAN
Ran query locally that previously returned a `"null"` schema. Confirmed it is now `null`.
### REVIEWERS
@john-bodley @graceguo-supercat
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
|