superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] etr2460 commented on a change in pull request #8138: [typing] add typing for superset/connectors and superset/common
Date Tue, 03 Sep 2019 17:11:02 GMT
etr2460 commented on a change in pull request #8138: [typing] add typing for superset/connectors
and superset/common
URL: https://github.com/apache/incubator-superset/pull/8138#discussion_r320381394
 
 

 ##########
 File path: superset/connectors/base/models.py
 ##########
 @@ -60,8 +60,8 @@ class BaseDatasource(AuditMixinNullable, ImportMixin):
     perm = Column(String(1000))
 
     sql = None
-    owners = None
 
 Review comment:
   What's the implication of removing this default value?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message