From notifications-return-24970-archive-asf-public=cust-asf.ponee.io@superset.apache.org Thu Aug 1 05:23:38 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B9B6E18062B for ; Thu, 1 Aug 2019 07:23:37 +0200 (CEST) Received: (qmail 96245 invoked by uid 500); 1 Aug 2019 05:23:37 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 96236 invoked by uid 99); 1 Aug 2019 05:23:37 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 01 Aug 2019 05:23:37 +0000 From: GitBox To: notifications@superset.apache.org Subject: [GitHub] [incubator-superset] arpit-agarwal removed a comment on issue #7955: Fix createDatasource Message-ID: <156463701704.25268.11328127468585226706.gitbox@gitbox.apache.org> Date: Thu, 01 Aug 2019 05:23:37 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit arpit-agarwal removed a comment on issue #7955: Fix createDatasource URL: https://github.com/apache/incubator-superset/pull/7955#issuecomment-517094487 Can you mention the the steps via that you found this issue? Theoretical earlier code and new one is identical. I can run few more tests and revert back. Have you rebuild frontend. I am assuming you're logging the response in fromtend ________________________________ From: Beto Dealmeida Sent: Thursday, August 1, 2019 2:44:34 AM To: apache/incubator-superset Cc: Arpit Agarwal ; Mention Subject: Re: [apache/incubator-superset] Fix createDatasource (#7955) @arpit-agarwal, your change in https://github.com/apache/incubator-superset/pull/7907/files is not working for me. If I log the response I get: {json: {table_id: 23}, response: Response} And because of this, data is undefined. cc: @villebro — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org