superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] villebro commented on a change in pull request #7951: [feat] Add d3 legend formatting for Arc, Polygon and Scatter deck.gl maps
Date Thu, 01 Aug 2019 14:09:18 GMT
villebro commented on a change in pull request #7951: [feat] Add d3 legend formatting for Arc,
Polygon and Scatter deck.gl maps
URL: https://github.com/apache/incubator-superset/pull/7951#discussion_r309714488
 
 

 ##########
 File path: superset/assets/src/visualizations/Legend.jsx
 ##########
 @@ -18,24 +18,52 @@
  */
 import React from 'react';
 import PropTypes from 'prop-types';
+import { format } from 'd3-format';
 
 Review comment:
   Same here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message