superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] arpit-agarwal removed a comment on issue #7955: Fix createDatasource
Date Thu, 01 Aug 2019 05:23:37 GMT
arpit-agarwal removed a comment on issue #7955: Fix createDatasource
URL: https://github.com/apache/incubator-superset/pull/7955#issuecomment-517094487
 
 
   Can you mention the the steps via that you found this issue?
   
   Theoretical earlier code and new one is identical. I can run few more tests and revert
back.
   Have you rebuild frontend.
   
   I am assuming you're logging the response in fromtend
   ________________________________
   From: Beto Dealmeida <notifications@github.com>
   Sent: Thursday, August 1, 2019 2:44:34 AM
   To: apache/incubator-superset <incubator-superset@noreply.github.com>
   Cc: Arpit Agarwal <Arpit.Agarwal@guavus.com>; Mention <mention@noreply.github.com>
   Subject: Re: [apache/incubator-superset] Fix createDatasource (#7955)
   
   
   @arpit-agarwal<https://github.com/arpit-agarwal>, your change in https://github.com/apache/incubator-superset/pull/7907/files
is not working for me. If I log the response I get:
   
   {json: {table_id: 23}, response: Response}
   
   And because of this, data is undefined.
   
   cc: @villebro<https://github.com/villebro>
   
   —
   You are receiving this because you were mentioned.
   Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-superset/pull/7955?email_source=notifications&email_token=ADGKPBWKSW43SUJL4P2KJ4LQCH6DVA5CNFSM4IIKQUI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3ISNGA#issuecomment-517023384>,
or mute the thread<https://github.com/notifications/unsubscribe-auth/ADGKPBUF52G2UF5RMBREZDDQCH6DVANCNFSM4IIKQUIQ>.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message