From notifications-return-21526-archive-asf-public=cust-asf.ponee.io@superset.apache.org Sun May 26 19:49:55 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BD0DF18062B for ; Sun, 26 May 2019 21:49:54 +0200 (CEST) Received: (qmail 55066 invoked by uid 500); 26 May 2019 19:49:50 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 55047 invoked by uid 99); 26 May 2019 19:49:50 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 26 May 2019 19:49:50 +0000 From: GitBox To: notifications@superset.apache.org Subject: [GitHub] [incubator-superset] cgivre commented on a change in pull request #6610: [WIP] Add support for Apache Drill Message-ID: <155890019075.25243.5814245634551360025.gitbox@gitbox.apache.org> Date: Sun, 26 May 2019 19:49:50 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit cgivre commented on a change in pull request #6610: [WIP] Add support for Apache Drill URL: https://github.com/apache/incubator-superset/pull/6610#discussion_r287611775 ########## File path: superset/db_engine_specs.py ########## @@ -721,6 +721,70 @@ def get_table_names(cls, inspector, schema): return sorted(inspector.get_table_names()) +class DrillEngineSpec(BaseEngineSpec): + """Engine spec for Apache Drill""" + engine = 'drill' Review comment: I think I'm going to leave this out for the moment as Drill allows some schema variants that it might break. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org