From notifications-return-21515-archive-asf-public=cust-asf.ponee.io@superset.apache.org Sun May 26 09:04:52 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 41F6C18062B for ; Sun, 26 May 2019 11:04:52 +0200 (CEST) Received: (qmail 42906 invoked by uid 500); 26 May 2019 09:04:51 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 42897 invoked by uid 99); 26 May 2019 09:04:51 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 26 May 2019 09:04:51 +0000 From: GitBox To: notifications@superset.apache.org Subject: [GitHub] [incubator-superset] codecov-io edited a comment on issue #7459: Excel support Message-ID: <155886149155.26410.17853050147909736524.gitbox@gitbox.apache.org> Date: Sun, 26 May 2019 09:04:51 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit codecov-io edited a comment on issue #7459: Excel support URL: https://github.com/apache/incubator-superset/pull/7459#issuecomment-489568364 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7459?src=pr&el=h1) Report > Merging [#7459](https://codecov.io/gh/apache/incubator-superset/pull/7459?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5cf454b4647c6f52b0e7ae49ec5251a46703dd31?src=pr&el=desc) will **decrease** coverage by `0.04%`. > The diff coverage is `75%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/7459/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/7459?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #7459 +/- ## ========================================== - Coverage 65.22% 65.18% -0.05% ========================================== Files 431 435 +4 Lines 21147 21539 +392 Branches 2343 2384 +41 ========================================== + Hits 13794 14041 +247 - Misses 7237 7378 +141 - Partials 116 120 +4 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/7459?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...uperset/assets/src/SqlLab/components/SouthPane.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7459/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9Tb3V0aFBhbmUuanN4) | `85.29% <ø> (ø)` | :arrow_up: | | [...ts/src/explore/components/ExploreActionButtons.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7459/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRXhwbG9yZUFjdGlvbkJ1dHRvbnMuanN4) | `100% <100%> (ø)` | :arrow_up: | | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/7459/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==) | `70.79% <100%> (+0.29%)` | :arrow_up: | | [...uperset/assets/src/SqlLab/components/ResultSet.jsx](https://codecov.io/gh/apache/incubator-superset/pull/7459/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvY29tcG9uZW50cy9SZXN1bHRTZXQuanN4) | `80.45% <100%> (+0.45%)` | :arrow_up: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/7459/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `94.01% <100%> (+0.22%)` | :arrow_up: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/7459/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.7% <25%> (+0.14%)` | :arrow_up: | | [superset/assets/src/explore/exploreUtils.js](https://codecov.io/gh/apache/incubator-superset/pull/7459/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2V4cGxvcmVVdGlscy5qcw==) | `75.23% <66.66%> (-0.5%)` | :arrow_down: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/7459/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.58% <81.48%> (-0.97%)` | :arrow_down: | | [superset/views/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/7459/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mvc3FsX2xhYi5weQ==) | `85.71% <0%> (-8.93%)` | :arrow_down: | | [superset/assets/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/7459/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9TcWxMYWIvYWN0aW9ucy9zcWxMYWIuanM=) | `63.31% <0%> (-7.33%)` | :arrow_down: | | ... and [49 more](https://codecov.io/gh/apache/incubator-superset/pull/7459/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7459?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/7459?src=pr&el=footer). Last update [5cf454b...b02ba50](https://codecov.io/gh/apache/incubator-superset/pull/7459?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org