From notifications-return-21492-archive-asf-public=cust-asf.ponee.io@superset.apache.org Sat May 25 21:33:37 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id A9C9218065D for ; Sat, 25 May 2019 23:33:36 +0200 (CEST) Received: (qmail 62685 invoked by uid 500); 25 May 2019 21:33:36 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 62676 invoked by uid 99); 25 May 2019 21:33:36 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 25 May 2019 21:33:36 +0000 From: GitBox To: notifications@superset.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-superset=5D_abhioncbr_commented_on_is?= =?utf-8?q?sue_=237372=3A_7366=3A_Added_requirements-fill=2Etxt_file_havin?= =?utf-8?q?g_mandatory_=26_optional_pa=E2=80=A6?= Message-ID: <155882001092.10168.842782851808384635.gitbox@gitbox.apache.org> Date: Sat, 25 May 2019 21:33:30 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit abhioncbr commented on issue #7372: 7366: Added requirements-fill.txt file having mandatory & optional pa… URL: https://github.com/apache/incubator-superset/pull/7372#issuecomment-495950201 @mistercrunch not very much sure that above-suggested changes. I would be thinking, It's good to merge the changes and create a new ticket for the above suggestions, as this PR is long pending. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org