From notifications-return-20073-archive-asf-public=cust-asf.ponee.io@superset.apache.org Thu May 2 06:41:32 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5C775180671 for ; Thu, 2 May 2019 08:41:32 +0200 (CEST) Received: (qmail 51928 invoked by uid 500); 2 May 2019 06:41:31 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 51919 invoked by uid 99); 2 May 2019 06:41:31 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 May 2019 06:41:31 +0000 From: GitBox To: notifications@superset.apache.org Subject: [GitHub] [incubator-superset] elukey commented on issue #7006: World map viz not working in 0.29rc7/0.31.0rc18/0.32 Message-ID: <155677929174.31016.6454094831682840619.gitbox@gitbox.apache.org> Date: Thu, 02 May 2019 06:41:31 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit elukey commented on issue #7006: World map viz not working in 0.29rc7/0.31.0rc18/0.32 URL: https://github.com/apache/incubator-superset/issues/7006#issuecomment-488567439 Update: after a bit of testing I decided to update the pull request to avoid all the conditionals logic and simply remove the use of .iloc. From my tests everything looks good, review/merge/etc.. would be really appreciated :) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org