From notifications-return-20072-archive-asf-public=cust-asf.ponee.io@superset.apache.org Thu May 2 06:40:45 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B3C19180671 for ; Thu, 2 May 2019 08:40:44 +0200 (CEST) Received: (qmail 51585 invoked by uid 500); 2 May 2019 06:40:44 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 51576 invoked by uid 99); 2 May 2019 06:40:43 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 May 2019 06:40:43 +0000 From: GitBox To: notifications@superset.apache.org Subject: [GitHub] [incubator-superset] elukey commented on issue #7379: Remove the use of Pandas' iloc() in WorldMapViz Message-ID: <155677923885.30650.9557071393189950486.gitbox@gitbox.apache.org> Date: Thu, 02 May 2019 06:40:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit elukey commented on issue #7379: Remove the use of Pandas' iloc() in WorldMapViz URL: https://github.com/apache/incubator-superset/pull/7379#issuecomment-488567302 @mistercrunch I think I finally found a good explanation of what broke the world map visualization. The change in my opinion is to remove the use of .iloc, from my tests it is the simplest solution and it solves all my visualization issues. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org