From notifications-return-19991-archive-asf-public=cust-asf.ponee.io@superset.apache.org Wed May 1 06:03:57 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 014BC18067E for ; Wed, 1 May 2019 08:03:56 +0200 (CEST) Received: (qmail 1392 invoked by uid 500); 1 May 2019 06:03:56 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 1374 invoked by uid 99); 1 May 2019 06:03:56 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 May 2019 06:03:56 +0000 From: GitBox To: notifications@superset.apache.org Subject: [GitHub] [incubator-superset] williaster commented on a change in pull request #7233: [dashboard] After update filter, trigger new queries when charts are visible Message-ID: <155669063568.16980.7773745983028053953.gitbox@gitbox.apache.org> Date: Wed, 01 May 2019 06:03:55 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit williaster commented on a change in pull request #7233: [dashboard] After update filter, trigger new queries when charts are visible URL: https://github.com/apache/incubator-superset/pull/7233#discussion_r280009653 ########## File path: superset/assets/src/explore/components/ExploreViewContainer.jsx ########## @@ -106,7 +106,6 @@ class ExploreViewContainer extends React.Component { componentWillReceiveProps(nextProps) { if (nextProps.controls.viz_type.value !== this.props.controls.viz_type.value) { this.props.actions.resetControls(); - this.props.actions.triggerQuery(true, this.props.chart.id); Review comment: sorry not sure I quite understand the explore view changes with the new flow, why do we remove this line? I get that `src/chart/Chart` will now trigger a query if its `prop.formData` prop changes, but its `props.triggerQuery` still has to be `true` right? does that only happen with this line or something else causes that? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org