superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] villebro commented on issue #7379: Remove the use of Pandas' iloc() in WorldMapViz
Date Mon, 27 May 2019 20:27:09 GMT
villebro commented on issue #7379: Remove the use of Pandas' iloc() in WorldMapViz
URL: https://github.com/apache/incubator-superset/pull/7379#issuecomment-496299757
 
 
   @elukey I was able to replicate the problem on master, i.e. when choosing the same metric
twice (color and bubble size), the error `Too many indexers` would show up. After applying
your fix the problem went away without causing adverse side-effects that I could tell. If
we want to be on the safe side, we could check if `df[metric]` is a `DataFrame` and call `iloc`
on that. But I agree that there shouldn't be duplicate columns anymore, so it might very well
just introduce unnecessary clutter into the codebase. So all in all LGTM.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message