superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] MarcusSorealheis opened a new pull request #7598: adding command for seeing FAB template changes reflected.
Date Mon, 27 May 2019 00:55:16 GMT
MarcusSorealheis opened a new pull request #7598: adding command for seeing FAB template changes
reflected.
URL: https://github.com/apache/incubator-superset/pull/7598
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Documentation
   
   ### SUMMARY
   
   Even though this is a legacy portion of the app that is likely to go away one day, the
FAB-managed templates still play a vital role to the application and some of its core features.
When I set to fix a bug in a FAB-managed template, I could not get the template to refresh.

   
   I learned through a bit of head-wall-butting and searching that removing `--with-threads`
from the run command might solve the problem due to a race condition. I don't have enough
information to say that's exactly what's going on for sure, but removing `--with-threads`
did result in my template pages being updated. 
   
   ### TEST PLAN
   
   1. Make a change to a template file managed by FAB and check to see if the change is reflected,
even after clearing your cache or browsing in incognito and start the app with:
   
   `FLASK_ENV=development superset run -p 8088 --with-threads --reload --debugger`
   
   2. Stop the server and try to start it again with this command:
   
   FLASK_ENV=development superset run -p 8088 --reload --debugger
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->        
 
   - [ ] Has associated issue: "Fixes [#7493](https://github.com/apache/incubator-superset/issues/7493)"
   
   ### REVIEWERS

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message