superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] elukey commented on issue #7379: Remove the use of Pandas' iloc() in WorldMapViz
Date Mon, 20 May 2019 06:08:25 GMT
elukey commented on issue #7379: Remove the use of Pandas' iloc() in WorldMapViz
URL: https://github.com/apache/incubator-superset/pull/7379#issuecomment-493850581
 
 
   > `iloc` was introduced because pandas' behavior changed when dealing with multiple
columns with the same key. Before it would return the first one, now it returns a dataframe
which broke things.
   > 
   > Does this work when the same metric is used twice?
   
   I am running superset 0.32 with some extra patches, including this one, and charts using
worlmap with the same metric reused as bubble size work fine now. 
   
   I have checked a couple of times the pandas' changelog to spot any new feature that could
have changed its behavior, but found none. After checking git blame for WorldMapViz though,
I noticed that the following bit in the commit that I have indicated seems now the responsible
for the need of .iloc or not:
   
   ```
       def query_obj(self):
           qry = super(WorldMapViz, self).query_obj()
   -        qry['metrics'] = [
   -            self.form_data['metric'], self.form_data['secondary_metric']]
           qry['groupby'] = [self.form_data['entity']]
           return qry
   ```
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message