superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] betodealmeida commented on a change in pull request #7508: Validate start/end when scheduling queries
Date Thu, 16 May 2019 01:01:08 GMT
betodealmeida commented on a change in pull request #7508: Validate start/end when scheduling
queries
URL: https://github.com/apache/incubator-superset/pull/7508#discussion_r284505994
 
 

 ##########
 File path: docs/installation.rst
 ##########
 @@ -858,13 +858,19 @@ To allow scheduled queries, add the following to your `config.py`:
                     },
                     'start_date': {
                         'type': 'string',
-                        'format': 'date-time',
                         'title': 'Start date',
+                        # date-time is parsed using the Sugar library, see
 
 Review comment:
   @khtruong we use `moment.js`, but it can't parse relative dates like these, which is what
we really want.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message