superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] betodealmeida opened a new pull request #7521: Show scheduled queries
Date Thu, 16 May 2019 00:03:20 GMT
betodealmeida opened a new pull request #7521: Show scheduled queries
URL: https://github.com/apache/incubator-superset/pull/7521
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [X] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   This PR shows scheduled information on saved queries that have them.
   
   In order to do this, I created a custom template for showing the saved query, extending
the native one from FAB. The template injects Javascript code and a `<div>`, and the
Javascript code inserts a `<Form>` component with the scheduled information.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   It looks ugly, but I'll fix the CSS in another PR:
   
   <img width="1698" alt="Screen Shot 2019-05-15 at 5 00 27 PM" src="https://user-images.githubusercontent.com/1534870/57817177-19b76e80-7733-11e9-9d2e-42f77c49eac7.png">
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   Tested locally.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   @mistercrunch @datability-io @DiggidyDave @khtruong 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message