superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] john-bodley commented on a change in pull request #7429: [sql lab] Fix setting async query status to timed_out
Date Thu, 02 May 2019 17:44:24 GMT
john-bodley commented on a change in pull request #7429: [sql lab] Fix setting async query
status to timed_out
URL: https://github.com/apache/incubator-superset/pull/7429#discussion_r280526964
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -2752,12 +2752,10 @@ def queries(self, last_updated_ms):
         ]
 
         if queries_to_timeout:
-            update(Query).where(
-                and_(
-                    Query.user_id == g.user.get_id(),
-                    Query.client_id in queries_to_timeout,
-                ),
-            ).values(state=QueryStatus.TIMED_OUT)
+            for q in sql_queries:
 
 Review comment:
   How many SQL queries are there? It may be more efficient to have the database handle this
logic.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message