superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] michellethomas opened a new pull request #7433: [WIP] Adding codecov targets and thresholds
Date Thu, 02 May 2019 17:28:53 GMT
michellethomas opened a new pull request #7433: [WIP] Adding codecov targets and thresholds
URL: https://github.com/apache/incubator-superset/pull/7433
 
 
   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [x] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   In [SIP-13](https://github.com/apache/incubator-superset/issues/6132) we discussed having
automated checks for code coverage (section [P.5.3]). This PR creates a codecov yaml for us
to set the targets and thresholds we want, so if we add a setting in the repo to prevent merging
if these rules aren't met, we can change them if we feel they are too strict.
   
   Questions:
   
   1. What do we want to set the patch target at? Setting a threshold of 1% will trigger if
your coverage is 1% below the coverage for the repo, but for diffs I think we should set a
specific target so we can improve the coverage of the repo as we work on features. Would love
to get input on what that number should be.
   2. Should we have folders we ignore? I initially put in the visualizations folder to ignore
because it's been difficult to add unit tests to cover this code, is that what we want? Are
there other folders to ignore?
   
   ### TEST PLAN
   Used codecov's validator `curl --data-binary @.codecov.yml https://codecov.io/validate`
   Tested on a PR on in my fork
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message