superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] bearcage commented on issue #7422: Add "validation_only" queries to the backend
Date Wed, 01 May 2019 16:15:47 GMT
bearcage commented on issue #7422: Add "validation_only" queries to the backend
URL: https://github.com/apache/incubator-superset/pull/7422#issuecomment-488329354
 
 
   Initially I had this in a separate endpoint, but it seemed like a lot of duplication of
effort to pull over all the other conditional modifications we do on queries before executing
them (limit, ctas, and templating). Templating in particular was what initially convinced
me to move this in to the query execution flow.
   
   That said, I'm not at all used to OSS projects, so I hadn't considered the rhetorical angle.
I'll split it back out.
   
   Point well taken on the name. How about `/validate_sql_json` for the endpoint and "SQL
Validation" as the name of the feature?
   
   ---
   
   Happy to add tests and typing — I have some tests which I'd planned to stack on this
commit. I'll squash them instead. Since this portion of the code isn't particularly liberal
with types, do y'all prefer py3-only annotations, or comment annotations?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message