superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] john-bodley commented on a change in pull request #7422: Add "validation_only" queries to the backend
Date Wed, 01 May 2019 16:00:25 GMT
john-bodley commented on a change in pull request #7422: Add "validation_only" queries to the
backend
URL: https://github.com/apache/incubator-superset/pull/7422#discussion_r280116294
 
 

 ##########
 File path: superset/db_engine_specs.py
 ##########
 @@ -487,6 +488,16 @@ def get_timestamp_column(expression, column_name):
         can be overridden."""
         return expression or column_name
 
+    @classmethod
+    def make_validation_query(cls, sql):
+        """
+        If the underlying engine supports it, modify the query sql to request
+        that the database validate the query instead of running it.
+        """
+        raise Exception(
 
 Review comment:
   How is this exception handled? Note historically Superset hasn’t been great at error
handling as these are often left uncaught resulting in 5xx errors.
   
   If raising an exception is indeed the right approach one should try not raise the base
`Exception` But rather something more specific.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message