From notifications-return-3443-archive-asf-public=cust-asf.ponee.io@superset.apache.org Wed Jul 18 16:04:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 13D91180636 for ; Wed, 18 Jul 2018 16:04:04 +0200 (CEST) Received: (qmail 79084 invoked by uid 500); 18 Jul 2018 14:04:04 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 79073 invoked by uid 99); 18 Jul 2018 14:04:04 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Jul 2018 14:04:04 +0000 From: GitBox To: notifications@superset.apache.org Subject: [GitHub] villebro commented on issue #5380: Add time grain blacklist and tests for validity Message-ID: <153192264362.14098.2009514722170125522.gitbox@gitbox.apache.org> Date: Wed, 18 Jul 2018 14:04:03 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit villebro commented on issue #5380: Add time grain blacklist and tests for validity URL: https://github.com/apache/incubator-superset/pull/5380#issuecomment-405942591 Also added functionality to be able to add new custom time grains in `config.py` (`TIME_GRAIN_ADDONS` and `TIME_GRAIN_ADDON_FUNCTIONS`). This could be used to move some less used time grains out of db_engine_specs, while still allowing for end users to define their own custom time grains where needed. Question: in `config.py`, which would be preferable: using a blacklist to remove predefined options (e.g. `VIZ_TYPE_BLACKLIST`), or effectively defining a whitelist (e.g. `LANGUAGES`)? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org