From notifications-return-2867-archive-asf-public=cust-asf.ponee.io@superset.apache.org Mon Jul 2 19:35:26 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 0884B180674 for ; Mon, 2 Jul 2018 19:35:25 +0200 (CEST) Received: (qmail 25213 invoked by uid 500); 2 Jul 2018 17:35:25 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 25204 invoked by uid 99); 2 Jul 2018 17:35:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Jul 2018 17:35:25 +0000 From: GitBox To: notifications@superset.apache.org Subject: [GitHub] timifasubaa commented on a change in pull request #5303: [csv-hive] Use schema form field in upload csv Message-ID: <153055292446.7497.7735185922924262638.gitbox@gitbox.apache.org> Date: Mon, 02 Jul 2018 17:35:24 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit timifasubaa commented on a change in pull request #5303: [csv-hive] Use schema form field in upload csv URL: https://github.com/apache/incubator-superset/pull/5303#discussion_r199570073 ########## File path: superset/db_engine_specs.py ########## @@ -984,14 +984,22 @@ def convert_to_hive_type(col_type): return tableschema_to_hive_types.get(col_type, 'STRING') table_name = form.name.data + schema_name = form.schema.data Review comment: It wasn't. Historically, you could only specify the namespace by making the table name `namespace.tablename`. The exception happens when the administrator forces all tables to be in one namespace. And in that case, any avenue used to specify a namespace (schema form field or namespace before table name) will lead to an exception. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org