superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] mistercrunch commented on a change in pull request #5415: Fix db migration 3dda56f1c4c6
Date Tue, 17 Jul 2018 21:30:46 GMT
mistercrunch commented on a change in pull request #5415: Fix db migration 3dda56f1c4c6
URL: https://github.com/apache/incubator-superset/pull/5415#discussion_r203185267
 
 

 ##########
 File path: superset/migrations/versions/3dda56f1c4c6_migrate_num_period_compare_and_period_.py
 ##########
 @@ -9,18 +9,20 @@
 from __future__ import division
 
 # revision identifiers, used by Alembic.
-revision = '3dda56f1c4c6'
-down_revision = 'bddc498dd179'
 
+import datetime
 import json
 
 from alembic import op
 import isodate
-import sqlalchemy as sa
 from sqlalchemy.ext.declarative import declarative_base
 from sqlalchemy import Column, Integer, Text
 
 from superset import db
+from superset.utils import parse_human_timedelta
 
 Review comment:
   this import was missing somehow

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message