superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] timifasubaa commented on a change in pull request #5303: [csv-hive] Use schema form field in upload csv
Date Mon, 02 Jul 2018 17:35:24 GMT
timifasubaa commented on a change in pull request #5303: [csv-hive] Use schema form field in
upload csv
URL: https://github.com/apache/incubator-superset/pull/5303#discussion_r199570073
 
 

 ##########
 File path: superset/db_engine_specs.py
 ##########
 @@ -984,14 +984,22 @@ def convert_to_hive_type(col_type):
             return tableschema_to_hive_types.get(col_type, 'STRING')
 
         table_name = form.name.data
+        schema_name = form.schema.data
 
 Review comment:
   It wasn't. Historically, you could only specify the namespace by making the table name
`namespace.tablename`.
   
   The exception happens when the administrator forces all tables to be in one namespace.
And in that case, any avenue used to specify a namespace (schema form field or namespace before
table name) will lead to an exception. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message