superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] codecov-io commented on issue #5211: [Bug fix] Divide by 1000.000 in epoch_ms_to_dttm() to not lose precision in Presto
Date Sun, 01 Jul 2018 21:49:15 GMT
codecov-io commented on issue #5211: [Bug fix] Divide by 1000.000 in epoch_ms_to_dttm() to
not lose precision in Presto
URL: https://github.com/apache/incubator-superset/pull/5211#issuecomment-401635613
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5211?src=pr&el=h1)
Report
   > Merging [#5211](https://codecov.io/gh/apache/incubator-superset/pull/5211?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-superset/commit/de0aaf42ed2e591b6122f6f7810c2e0e7886c52e?src=pr&el=desc)
will **decrease** coverage by `16.15%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5211/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5211?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           master    #5211       +/-   ##
   ===========================================
   - Coverage   77.48%   61.32%   -16.16%     
   ===========================================
     Files          44      369      +325     
     Lines        8749    23488    +14739     
     Branches        0     2717     +2717     
   ===========================================
   + Hits         6779    14405     +7626     
   - Misses       1970     9071     +7101     
   - Partials        0       12       +12
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5211?src=pr&el=tree)
| Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/5211/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5)
| `54.28% <ø> (+0.56%)` | :arrow_up: |
   | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/5211/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==)
| `71.6% <0%> (-3.81%)` | :arrow_down: |
   | [superset/dataframe.py](https://codecov.io/gh/apache/incubator-superset/pull/5211/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWZyYW1lLnB5)
| `94.49% <0%> (-3.21%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5211/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==)
| `72.96% <0%> (-1.71%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5211/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=)
| `85.29% <0%> (-1.26%)` | :arrow_down: |
   | [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/5211/diff?src=pr&el=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=)
| `72.32% <0%> (-0.79%)` | :arrow_down: |
   | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/5211/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=)
| `87.8% <0%> (-0.72%)` | :arrow_down: |
   | [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/5211/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==)
| `100% <0%> (ø)` | :arrow_up: |
   | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5211/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=)
| `80.56% <0%> (ø)` | :arrow_up: |
   | [...sets/src/explore/components/DisplayQueryButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5211/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRGlzcGxheVF1ZXJ5QnV0dG9uLmpzeA==)
| `84.21% <0%> (ø)` | |
   | ... and [328 more](https://codecov.io/gh/apache/incubator-superset/pull/5211/diff?src=pr&el=tree-more)
| |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5211?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5211?src=pr&el=footer).
Last update [de0aaf4...c6abfe9](https://codecov.io/gh/apache/incubator-superset/pull/5211?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message