From notifications-return-1687-archive-asf-public=cust-asf.ponee.io@superset.apache.org Thu Jun 7 01:05:37 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 25DEB180671 for ; Thu, 7 Jun 2018 01:05:36 +0200 (CEST) Received: (qmail 2929 invoked by uid 500); 6 Jun 2018 23:05:36 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 2920 invoked by uid 99); 6 Jun 2018 23:05:36 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jun 2018 23:05:36 +0000 From: GitBox To: notifications@superset.apache.org Subject: [GitHub] graceguo-supercat commented on a change in pull request #5141: allow add chart from explore view Message-ID: <152832633568.11938.12953468516483724843.gitbox@gitbox.apache.org> Date: Wed, 06 Jun 2018 23:05:35 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit graceguo-supercat commented on a change in pull request #5141: allow add chart from explore view URL: https://github.com/apache/incubator-superset/pull/5141#discussion_r193585361 ########## File path: superset/assets/src/dashboard/util/findFirstParentContainer.js ########## @@ -0,0 +1,19 @@ +import { TABS_TYPE } from './componentTypes'; Review comment: added test. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org