From notifications-return-1666-archive-asf-public=cust-asf.ponee.io@superset.apache.org Wed Jun 6 19:02:32 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 68EC9180671 for ; Wed, 6 Jun 2018 19:02:31 +0200 (CEST) Received: (qmail 64637 invoked by uid 500); 6 Jun 2018 17:02:30 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 64626 invoked by uid 99); 6 Jun 2018 17:02:30 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 06 Jun 2018 17:02:30 +0000 From: GitBox To: notifications@superset.apache.org Subject: [GitHub] mistercrunch commented on issue #5143: strip druid metric type when value is postagg Message-ID: <152830454988.6263.18121983659003118115.gitbox@gitbox.apache.org> Date: Wed, 06 Jun 2018 17:02:29 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit mistercrunch commented on issue #5143: strip druid metric type when value is postagg URL: https://github.com/apache/incubator-superset/pull/5143#issuecomment-395141886 Personally would prefer getting that right on the way in as the data is saved instead of adding `.strip()` everywhere we use user inputed data in the codebase. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org