From notifications-return-1462-archive-asf-public=cust-asf.ponee.io@superset.apache.org Fri Jun 1 07:59:55 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3E130180676 for ; Fri, 1 Jun 2018 07:59:55 +0200 (CEST) Received: (qmail 48698 invoked by uid 500); 1 Jun 2018 05:59:54 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 48689 invoked by uid 99); 1 Jun 2018 05:59:54 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jun 2018 05:59:54 +0000 From: GitBox To: notifications@superset.apache.org Subject: [GitHub] codecov-io commented on issue #4834: Load async sql lab results early for Presto Message-ID: <152783279370.3128.5438117730127142626.gitbox@gitbox.apache.org> Date: Fri, 01 Jun 2018 05:59:53 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit codecov-io commented on issue #4834: Load async sql lab results early for Presto URL: https://github.com/apache/incubator-superset/pull/4834#issuecomment-383803145 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4834?src=pr&el=h1) Report > Merging [#4834](https://codecov.io/gh/apache/incubator-superset/pull/4834?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/556ef44fac4ef77da2098cc49950f3d1de78658f?src=pr&el=desc) will **decrease** coverage by `0.29%`. > The diff coverage is `50.6%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/4834/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/4834?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4834 +/- ## ========================================= - Coverage 77.51% 77.22% -0.3% ========================================= Files 44 44 Lines 8735 8780 +45 ========================================= + Hits 6771 6780 +9 - Misses 1964 2000 +36 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4834?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/4834/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `89.08% <100%> (+0.55%)` | :arrow_up: | | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/4834/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.42% <100%> (+0.11%)` | :arrow_up: | | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/4834/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `51.8% <21.05%> (-2.19%)` | :arrow_down: | | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/4834/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `69.36% <31.25%> (-6.05%)` | :arrow_down: | | [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4834/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `80.53% <0%> (ø)` | :arrow_up: | | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/4834/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `81.42% <0%> (+0.04%)` | :arrow_up: | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4834?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4834?src=pr&el=footer). Last update [556ef44...8d54892](https://codecov.io/gh/apache/incubator-superset/pull/4834?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org