superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] williaster opened a new pull request #5151: [dashboard v2] better grid drop ux, fix tab bugs 🐛
Date Wed, 06 Jun 2018 23:54:13 GMT
williaster opened a new pull request #5151: [dashboard v2]  better grid drop ux, fix tab bugs
🐛
URL: https://github.com/apache/incubator-superset/pull/5151
 
 
   This PR
   - adds an empty drop target to the `DashboardGrid` to increase the drop zone surface area
for better UX
   - fixes a bug where deletion of top-level tabs when a non-zero tab index was selected resulted
in an empty screen because the tabIndex was not reset
   - fixes a bug in `findParentId` 🤦‍♂️ 
   
   @graceguo-supercat 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message