superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] mistercrunch commented on a change in pull request #5100: Fix form data issue switching viz types
Date Fri, 01 Jun 2018 05:27:47 GMT
mistercrunch commented on a change in pull request #5100: Fix form data issue switching viz
types
URL: https://github.com/apache/incubator-superset/pull/5100#discussion_r192300979
 
 

 ##########
 File path: superset/assets/src/explore/components/ExploreViewContainer.jsx
 ##########
 @@ -299,14 +300,32 @@ class ExploreViewContainer extends React.Component {
 ExploreViewContainer.propTypes = propTypes;
 
 function mapStateToProps({ explore, charts, impressionId }) {
-  const form_data = getFormDataFromControls(explore.controls);
+  const rawFormDataControls = getControlsState(explore, explore.rawFormData);
+  const controls = Object.assign({}, explore.controls);
+  const formData = getFormDataFromControls(controls);
 
 Review comment:
   I think you can just `getFormDataFromControls(explore.controls);` here and remove the previous
line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message