superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jasnovak commented on a change in pull request #4900: Hide restricted ui elements, remove <br> from error message
Date Thu, 03 May 2018 18:23:44 GMT
jasnovak commented on a change in pull request #4900: Hide restricted ui elements, remove <br>
from error message
URL: https://github.com/apache/incubator-superset/pull/4900#discussion_r185894866
 
 

 ##########
 File path: superset/assets/src/dashboard/components/SliceHeader.jsx
 ##########
 @@ -1,13 +1,16 @@
 import React from 'react';
 import PropTypes from 'prop-types';
 import moment from 'moment';
+import { connect } from 'react-redux';
 
 import { t } from '../../locales';
 import EditableTitle from '../../components/EditableTitle';
 import TooltipWrapper from '../../components/TooltipWrapper';
 
 const propTypes = {
   slice: PropTypes.object.isRequired,
+  superset_can_explore: PropTypes.bool,
+  slice_can_edit: PropTypes.bool,
 
 Review comment:
   Same as above. I matched the prevalent style in the code for permission variables, but
can do camel case instead if you'd like.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message