superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michel...@apache.org
Subject [incubator-superset] branch master updated: Revert "[database] Fix, Removes the limit for the page size (#7987)" (#7995)
Date Tue, 06 Aug 2019 23:14:38 GMT
This is an automated email from the ASF dual-hosted git repository.

michellet pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new b62c122  Revert "[database] Fix, Removes the limit for the page size (#7987)" (#7995)
b62c122 is described below

commit b62c122b4d482028c20c6a9f12363c4f8fa30299
Author: Erik Ritter <erik.ritter@airbnb.com>
AuthorDate: Tue Aug 6 16:14:27 2019 -0700

    Revert "[database] Fix, Removes the limit for the page size (#7987)" (#7995)
    
    This reverts commit 8db419fe99ce3e3c940d6ba41ddae2528fd67995.
---
 superset/assets/src/components/TableSelector.jsx | 3 +--
 superset/views/database/api.py                   | 2 --
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/superset/assets/src/components/TableSelector.jsx b/superset/assets/src/components/TableSelector.jsx
index 9ead6dd..d380241 100644
--- a/superset/assets/src/components/TableSelector.jsx
+++ b/superset/assets/src/components/TableSelector.jsx
@@ -218,8 +218,7 @@ export default class TableSelector extends React.PureComponent {
           '/api/v1/database/?q=' +
           '(keys:!(none),' +
           'filters:!((col:expose_in_sqllab,opr:eq,value:!t)),' +
-          'order_columns:database_name,order_direction:asc,' +
-          'page:0,page_size:-1)'
+          'order_columns:database_name,order_direction:asc)'
         }
         onChange={this.onDatabaseChange}
         onAsyncError={() => this.props.handleError(t('Error while fetching database list'))}
diff --git a/superset/views/database/api.py b/superset/views/database/api.py
index 2bb8ea5..dea17ba 100644
--- a/superset/views/database/api.py
+++ b/superset/views/database/api.py
@@ -50,8 +50,6 @@ class DatabaseRestApi(DatabaseMixin, ModelRestApi):
         "allows_subquery",
         "backend",
     ]
-    # Removes the local limit for the page size
-    max_page_size = -1
 
 
 appbuilder.add_api(DatabaseRestApi)


Mime
View raw message