superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: Fix #7130 - SQL Lab table name autocomplete (#7926)
Date Sun, 28 Jul 2019 00:42:47 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 5f98d66  Fix #7130 - SQL Lab table name autocomplete (#7926)
5f98d66 is described below

commit 5f98d661f835ad2ebcb3aa638a72c9c2c48114e0
Author: Maxime Beauchemin <maximebeauchemin@gmail.com>
AuthorDate: Sat Jul 27 17:42:41 2019 -0700

    Fix #7130 - SQL Lab table name autocomplete (#7926)
---
 superset/assets/src/SqlLab/components/AceEditorWrapper.jsx | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/superset/assets/src/SqlLab/components/AceEditorWrapper.jsx b/superset/assets/src/SqlLab/components/AceEditorWrapper.jsx
index 7815998..661b7d0 100644
--- a/superset/assets/src/SqlLab/components/AceEditorWrapper.jsx
+++ b/superset/assets/src/SqlLab/components/AceEditorWrapper.jsx
@@ -156,7 +156,7 @@ class AceEditorWrapper extends React.PureComponent {
     const tables = props.tables || [];
     const extendedTables = props.extendedTables || [];
     tables.forEach((t) => {
-      const tableName = t.value.table;
+      const tableName = t.value;
       words.push({ name: t.label, value: tableName, score: 55, meta: 'table' });
       const extendedTable = extendedTables.find(et => et.name === tableName);
       const cols = extendedTable && extendedTable.columns || [];
@@ -167,7 +167,6 @@ class AceEditorWrapper extends React.PureComponent {
     words = words.concat(Object.keys(columns).map(col => (
       { name: col, value: col, score: 50, meta: 'column' }
     )), sqlWords);
-
     this.setState({ words }, () => {
       const completer = {
         getCompletions: this.getCompletions.bind(this),


Mime
View raw message