From commits-return-2861-archive-asf-public=cust-asf.ponee.io@superset.incubator.apache.org Sun Jun 23 21:22:14 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 899CD180679 for ; Sun, 23 Jun 2019 23:22:14 +0200 (CEST) Received: (qmail 11505 invoked by uid 500); 23 Jun 2019 21:22:14 -0000 Mailing-List: contact commits-help@superset.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.incubator.apache.org Delivered-To: mailing list commits@superset.incubator.apache.org Received: (qmail 11496 invoked by uid 99); 23 Jun 2019 21:22:13 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 23 Jun 2019 21:22:13 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id CC33A87AD7; Sun, 23 Jun 2019 21:22:13 +0000 (UTC) Date: Sun, 23 Jun 2019 21:22:13 +0000 To: "commits@superset.apache.org" Subject: [incubator-superset] branch master updated: fix(filterbox): fixed runtime exception in filterbox for allow multiple selection is false (#7011) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <156132493319.9611.15955620383410614158@gitbox.apache.org> From: maximebeauchemin@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-superset X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 1c4092c61cc8aeb3f3c0dabb7831813e514dfbdd X-Git-Newrev: 9c0c16c71b0fd9ef82b86f7fbf0f9d297820436a X-Git-Rev: 9c0c16c71b0fd9ef82b86f7fbf0f9d297820436a X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. maximebeauchemin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/master by this push: new 9c0c16c fix(filterbox): fixed runtime exception in filterbox for allow multiple selection is false (#7011) 9c0c16c is described below commit 9c0c16c71b0fd9ef82b86f7fbf0f9d297820436a Author: jiten-github AuthorDate: Mon Jun 24 02:52:07 2019 +0530 fix(filterbox): fixed runtime exception in filterbox for allow multiple selection is false (#7011) --- superset/utils/core.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset/utils/core.py b/superset/utils/core.py index c2ad7a7..d7a95ec 100644 --- a/superset/utils/core.py +++ b/superset/utils/core.py @@ -840,7 +840,7 @@ def merge_extra_filters(form_data: dict): if date_options.get(filtr['col']): if filtr.get('val'): form_data[date_options[filtr['col']]] = filtr['val'] - elif filtr['val'] and len(filtr['val']): + elif filtr['val']: # Merge column filters filter_key = get_filter_key(filtr) if filter_key in existing_filters: