From commits-return-2825-archive-asf-public=cust-asf.ponee.io@superset.incubator.apache.org Mon Jun 10 23:10:40 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id EFFBB180649 for ; Tue, 11 Jun 2019 01:10:39 +0200 (CEST) Received: (qmail 4195 invoked by uid 500); 10 Jun 2019 23:10:39 -0000 Mailing-List: contact commits-help@superset.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.incubator.apache.org Delivered-To: mailing list commits@superset.incubator.apache.org Received: (qmail 4186 invoked by uid 99); 10 Jun 2019 23:10:39 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 10 Jun 2019 23:10:39 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 37E5C87A99; Mon, 10 Jun 2019 23:10:39 +0000 (UTC) Date: Mon, 10 Jun 2019 23:10:38 +0000 To: "commits@superset.apache.org" Subject: [incubator-superset] branch master updated: Revert "Allow bigint to be used as time column in Presto" #7670 (#7678) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <156020823861.4679.8495593081485044164@gitbox.apache.org> From: johnbodley@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-superset X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: c6179b195f8c5f482928055803344a0e2f313bcc X-Git-Newrev: 49390b323215aceac9c7ff57077120a7d13d693b X-Git-Rev: 49390b323215aceac9c7ff57077120a7d13d693b X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. johnbodley pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/master by this push: new 49390b3 Revert "Allow bigint to be used as time column in Presto" #7670 (#7678) 49390b3 is described below commit 49390b323215aceac9c7ff57077120a7d13d693b Author: John Bodley <4567245+john-bodley@users.noreply.github.com> AuthorDate: Mon Jun 10 16:10:20 2019 -0700 Revert "Allow bigint to be used as time column in Presto" #7670 (#7678) --- superset/db_engine_specs/presto.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/superset/db_engine_specs/presto.py b/superset/db_engine_specs/presto.py index 79c58b9..b29b003 100644 --- a/superset/db_engine_specs/presto.py +++ b/superset/db_engine_specs/presto.py @@ -355,8 +355,6 @@ class PrestoEngineSpec(BaseEngineSpec): return "from_iso8601_date('{}')".format(dttm.isoformat()[:10]) if tt == 'TIMESTAMP': return "from_iso8601_timestamp('{}')".format(dttm.isoformat()) - if tt == 'BIGINT': - return "to_unixtime(from_iso8601_timestamp('{}'))".format(dttm.isoformat()) return "'{}'".format(dttm.strftime('%Y-%m-%d %H:%M:%S')) @classmethod