From commits-return-2788-archive-asf-public=cust-asf.ponee.io@superset.incubator.apache.org Wed Jun 5 05:59:44 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2163F18065D for ; Wed, 5 Jun 2019 07:59:44 +0200 (CEST) Received: (qmail 23869 invoked by uid 500); 5 Jun 2019 05:59:43 -0000 Mailing-List: contact commits-help@superset.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.incubator.apache.org Delivered-To: mailing list commits@superset.incubator.apache.org Received: (qmail 23860 invoked by uid 99); 5 Jun 2019 05:59:43 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Jun 2019 05:59:43 +0000 Received: by gitbox.apache.org (ASF Mail Server at gitbox.apache.org, from userid 33) id 621D68AAF6; Wed, 5 Jun 2019 05:59:43 +0000 (UTC) Date: Wed, 05 Jun 2019 05:59:43 +0000 To: "commits@superset.apache.org" Subject: [incubator-superset] branch master updated: [SQL Lab] CTAS now uses the right async configuration (#7175) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Message-ID: <155971438281.9581.942526344976000945@gitbox.apache.org> From: maximebeauchemin@apache.org X-Git-Host: gitbox.apache.org X-Git-Repo: incubator-superset X-Git-Refname: refs/heads/master X-Git-Reftype: branch X-Git-Oldrev: 25da4c773b1cd358d9b50ce3ce3e3835573783da X-Git-Newrev: 1cd0e7f3f44763f844c737aceb1306c38d816ca4 X-Git-Rev: 1cd0e7f3f44763f844c737aceb1306c38d816ca4 X-Git-NotificationType: ref_changed_plus_diff X-Git-Multimail-Version: 1.5.dev Auto-Submitted: auto-generated This is an automated email from the ASF dual-hosted git repository. maximebeauchemin pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-superset.git The following commit(s) were added to refs/heads/master by this push: new 1cd0e7f [SQL Lab] CTAS now uses the right async configuration (#7175) 1cd0e7f is described below commit 1cd0e7f3f44763f844c737aceb1306c38d816ca4 Author: Enrico Berti AuthorDate: Wed Jun 5 07:59:36 2019 +0200 [SQL Lab] CTAS now uses the right async configuration (#7175) Closes #6224 --- superset/assets/src/SqlLab/components/SqlEditor.jsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/superset/assets/src/SqlLab/components/SqlEditor.jsx b/superset/assets/src/SqlLab/components/SqlEditor.jsx index 5d58b23..4310768 100644 --- a/superset/assets/src/SqlLab/components/SqlEditor.jsx +++ b/superset/assets/src/SqlLab/components/SqlEditor.jsx @@ -242,10 +242,10 @@ class SqlEditor extends React.PureComponent { } runQuery() { if (this.props.database) { - this.startQuery(this.props.database.allow_run_async); + this.startQuery(); } } - startQuery(runAsync = false, ctas = false) { + startQuery(ctas = false) { const qe = this.props.queryEditor; const query = { dbId: qe.dbId, @@ -256,7 +256,7 @@ class SqlEditor extends React.PureComponent { tempTableName: ctas ? this.state.ctas : '', templateParams: qe.templateParams, queryLimit: qe.queryLimit || this.props.defaultQueryLimit, - runAsync, + runAsync: this.props.database ? this.props.database.allow_run_async : false, ctas, }; this.props.actions.runQuery(query); @@ -268,7 +268,7 @@ class SqlEditor extends React.PureComponent { } } createTableAs() { - this.startQuery(true, true); + this.startQuery(true); } ctasChanged(event) { this.setState({ ctas: event.target.value });