superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From michel...@apache.org
Subject [incubator-superset] 01/02: css: add margin-top to ResultSet (#7679)
Date Mon, 24 Jun 2019 20:54:37 GMT
This is an automated email from the ASF dual-hosted git repository.

michellet pushed a commit to branch release--0.33
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git

commit c8025b26c8d291d8949b23801b8af598ded5994a
Author: Maxime Beauchemin <maximebeauchemin@gmail.com>
AuthorDate: Mon Jun 17 22:57:40 2019 -0700

    css: add margin-top to ResultSet (#7679)
    
    
    (cherry picked from commit f278faa8be4ead1046c0b41c482d27f4f93976b4)
---
 superset/assets/src/SqlLab/components/ResultSet.jsx | 2 ++
 superset/assets/src/SqlLab/main.less                | 8 ++++++++
 2 files changed, 10 insertions(+)

diff --git a/superset/assets/src/SqlLab/components/ResultSet.jsx b/superset/assets/src/SqlLab/components/ResultSet.jsx
index 22b6b0d..98f357e 100644
--- a/superset/assets/src/SqlLab/components/ResultSet.jsx
+++ b/superset/assets/src/SqlLab/components/ResultSet.jsx
@@ -73,6 +73,7 @@ export default class ResultSet extends React.PureComponent {
     // when new results comes in, save them locally and clear in store
     if (this.props.cache && (!nextProps.query.cached)
       && nextProps.query.results
+      && nextProps.query.results.data
       && nextProps.query.results.data.length > 0) {
       this.setState(
         { data: nextProps.query.results.data },
@@ -227,6 +228,7 @@ export default class ResultSet extends React.PureComponent {
       return (
         <Button
           bsSize="sm"
+          className="fetch"
           bsStyle="primary"
           onClick={this.reFetchQueryResults.bind(this, query)}
         >
diff --git a/superset/assets/src/SqlLab/main.less b/superset/assets/src/SqlLab/main.less
index 8faf6fb..e3e2679 100644
--- a/superset/assets/src/SqlLab/main.less
+++ b/superset/assets/src/SqlLab/main.less
@@ -422,3 +422,11 @@ a.Link {
         margin-right: 3px;
     }
 }
+
+.SouthPane .tab-content .alert {
+    margin-top: 10px;
+}
+
+.SouthPane .tab-content button.fetch {
+    margin-top: 10px;
+}


Mime
View raw message