superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From johnbod...@apache.org
Subject [incubator-superset] branch master updated: [testconn] Fixing response (#7753)
Date Tue, 25 Jun 2019 06:07:49 GMT
This is an automated email from the ASF dual-hosted git repository.

johnbodley pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 0c9e6d0  [testconn] Fixing response (#7753)
0c9e6d0 is described below

commit 0c9e6d09858027ced2fee78cec8a4023d4207762
Author: John Bodley <4567245+john-bodley@users.noreply.github.com>
AuthorDate: Mon Jun 24 23:07:41 2019 -0700

    [testconn] Fixing response (#7753)
---
 superset/views/core.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/superset/views/core.py b/superset/views/core.py
index 06727f7..cc3b184 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -1546,7 +1546,7 @@ class Superset(BaseSupersetView):
                 metrics = col.get_metrics().values()
                 col.datasource.add_missing_metrics(metrics)
             db.session.commit()
-        return json_success('OK')
+        return json_success('"OK"')
 
     @api
     @has_access_api
@@ -1838,7 +1838,8 @@ class Superset(BaseSupersetView):
             engine = create_engine(uri, **engine_params)
 
             with closing(engine.connect()) as conn:
-                return json_success(json.dumps(conn.scalar(select([1]))))
+                conn.scalar(select([1]))
+                return json_success('"OK"')
         except Exception as e:
             logging.exception(e)
             return json_error_response((


Mime
View raw message