superset-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From maximebeauche...@apache.org
Subject [incubator-superset] branch master updated: Show generic error msg and hide stacktrace if feature flag is enabled (#7764)
Date Tue, 25 Jun 2019 04:11:11 GMT
This is an automated email from the ASF dual-hosted git repository.

maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-superset.git


The following commit(s) were added to refs/heads/master by this push:
     new d06b77c  Show generic error msg and hide stacktrace if feature flag is enabled (#7764)
d06b77c is described below

commit d06b77c3fde4fb6defae2ef1ce430c4e3f909c19
Author: Rahul Rahul <42782121+rahul-rahul-sp@users.noreply.github.com>
AuthorDate: Mon Jun 24 23:11:04 2019 -0500

    Show generic error msg and hide stacktrace if feature flag is enabled (#7764)
    
    * Show generic error msg and hide stacktrace if feature flag is enabled
    
    * SHOW_STACKTRACE should not modify msg
---
 superset/views/base.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/superset/views/base.py b/superset/views/base.py
index 2d14622..3c082a5 100644
--- a/superset/views/base.py
+++ b/superset/views/base.py
@@ -65,7 +65,7 @@ def get_error_msg():
 def json_error_response(msg=None, status=500, stacktrace=None, payload=None, link=None):
     if not payload:
         payload = {'error': '{}'.format(msg)}
-        if stacktrace:
+        if stacktrace and conf.get('SHOW_STACKTRACE'):
             payload['stacktrace'] = stacktrace
     if link:
         payload['link'] = link


Mime
View raw message